Skip to content

Synthesize reservoir data on the simulator#743

Closed
bharat wants to merge 1 commit into
LoopKit:devfrom
bharat:dev-simulator
Closed

Synthesize reservoir data on the simulator#743
bharat wants to merge 1 commit into
LoopKit:devfrom
bharat:dev-simulator

Conversation

@bharat
Copy link
Copy Markdown

@bharat bharat commented Jun 16, 2018

This enables the simulator to generated glucose predictions.

This enables the simulator to generated glucose predictions.
@ps2
Copy link
Copy Markdown
Collaborator

ps2 commented Jun 19, 2018

This does not actually synthesize reservoir data. Are you using something else to get the data into HK on the simulator?

@bharat
Copy link
Copy Markdown
Author

bharat commented Jun 19, 2018

The description of the commit itself could be better, sorry. I originally set out to synthesize whatever was necessary to get the simulator to do predictions. It turned out that all that was necessary was to have a pumpStatusDate so I left it at that.

This is highly useful when you're working on the simulator.

@ps2
Copy link
Copy Markdown
Collaborator

ps2 commented Jun 21, 2018

Any #if IOS_SIMULATOR defines mean that we have code that is untested when run on the simulator. In general testing should be done on a real device, at least for large features.

One thing you could do is take the database on disk from the LoopKit Example container and move it to Loop’s container, or it would be OK with a separate app target in the Loop project that generates data in various ways, since apps in the same app group container share a database anyway.

@bharat
Copy link
Copy Markdown
Author

bharat commented Jun 21, 2018

ok, makes sense. let's close this out and I'll try a different approach. I've largely moved off of the simulator so my need for this is much less pressing.

@bharat bharat closed this Jun 21, 2018
@bharat bharat deleted the dev-simulator branch October 12, 2018 23:06
loopkitdev pushed a commit to loopkitdev/Loop that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants